From: Nick Porter <nick@portercomputing.co.uk>
Date: Wed, 25 Oct 2023 09:26:48 +0000 (+0100)
Subject: Explicitly free list of VPs to maintain list integrity
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=791f6873d67b7a905022802fd4ac9c3abfbd92e2;p=thirdparty%2Ffreeradius-server.git

Explicitly free list of VPs to maintain list integrity
---

diff --git a/src/bin/radsniff.c b/src/bin/radsniff.c
index 4fdc05ff9b6..966f613053e 100644
--- a/src/bin/radsniff.c
+++ b/src/bin/radsniff.c
@@ -1519,7 +1519,11 @@ static void rs_packet_process(uint64_t count, rs_event_t *event, struct pcap_pkt
 				status = RS_RTX;
 				original->rt_rsp++;
 
-				fr_radius_packet_free(&original->linked);	/* Also frees vps */
+				/*
+				 *	Explicitly free VPs first so list maintains integrity - it is reused below
+				 */
+				fr_pair_list_free(&original->link_vps);
+				fr_radius_packet_free(&original->linked);
 				fr_event_timer_delete(&original->event);
 			/*
 			 *	...nope it's the first response to a request.