From: Michael Brown <mcb30@ipxe.org>
Date: Fri, 4 May 2012 14:32:20 +0000 (+0100)
Subject: [crypto] Fix memory leak in cms_verify_digest()
X-Git-Tag: v1.20.1~1813
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=793b8b08931c8a4b89a9ac3348670705b7d5183e;p=thirdparty%2Fipxe.git

[crypto] Fix memory leak in cms_verify_digest()

Detected using Valgrind.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
---

diff --git a/src/crypto/cms.c b/src/crypto/cms.c
index 12f17810f..04fc2a885 100644
--- a/src/crypto/cms.c
+++ b/src/crypto/cms.c
@@ -509,9 +509,10 @@ static int cms_verify_digest ( struct cms_signature *sig,
 				    info->signature_len ) ) != 0 ) {
 		DBGC ( sig, "CMS %p/%p signature verification failed: %s\n",
 		       sig, info, strerror ( rc ) );
-		return rc;
+		goto err_verify;
 	}
 
+ err_verify:
 	pubkey_final ( pubkey, ctx );
  err_init:
 	return rc;