From: Joel Brobecker Date: Fri, 27 Mar 2015 13:37:34 +0000 (-0700) Subject: Initialize EXPR in dtrace-probe::dtrace_process_dof_probe X-Git-Tag: users/hjl/linux/release/2.25.51.0.2~2^2~19^2~99 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79498702ef5f743481ee39c18418776715addcd6;p=thirdparty%2Fbinutils-gdb.git Initialize EXPR in dtrace-probe::dtrace_process_dof_probe GCC 4.4.7 generates the following warning: | cc1: warnings being treated as errors | dtrace-probe.c: In function ‘dtrace_process_dof_probe’: | dtrace-probe.c:416: error: ‘expr’ may be used uninitialized in this function | make[2]: *** [dtrace-probe.o] Error 1 Later versions (GCC 5) do a better job and don't generate the warning, but it does not hurt to pre-initialize "expr" to NULL. gdb/ChangeLog: * dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 3ef965c9f73..72940b0fc65 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-03-27 Joel Brobecker + + * dtrace-probe.c (dtrace_process_dof_probe): Initialize expr to NULL. + 2015-03-27 Andrzej Kaczmarek * gdb_bfd.c (gdb_bfd_section_index): Fix off-by-one for special diff --git a/gdb/dtrace-probe.c b/gdb/dtrace-probe.c index ff7ce7d868f..3f2548ddc4c 100644 --- a/gdb/dtrace-probe.c +++ b/gdb/dtrace-probe.c @@ -413,7 +413,7 @@ dtrace_process_dof_probe (struct objfile *objfile, for (j = 0; j < ret->probe_argc; j++) { struct dtrace_probe_arg arg; - struct expression *expr; + struct expression *expr = NULL; /* Set arg.expr to ensure all fields in expr are initialized and the compiler will not warn when arg is used. */