From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 25 May 2021 21:08:50 +0000 (+0200)
Subject: core: log about all errors in path_spec_watch()
X-Git-Tag: v249-rc1~149^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=795125cd1142c0eee7138d72bad2ff344e1b5468;p=thirdparty%2Fsystemd.git

core: log about all errors in path_spec_watch()

So far we logged about most, but not all errors. Adding log to all
errors.
---

diff --git a/src/core/path.c b/src/core/path.c
index 0512287baf7..355f6c645d4 100644
--- a/src/core/path.c
+++ b/src/core/path.c
@@ -55,13 +55,15 @@ int path_spec_watch(PathSpec *s, sd_event_io_handler_t handler) {
 
         s->inotify_fd = inotify_init1(IN_NONBLOCK|IN_CLOEXEC);
         if (s->inotify_fd < 0) {
-                r = -errno;
+                r = log_error_errno(errno, "Failed to allocate inotify fd: %m");
                 goto fail;
         }
 
         r = sd_event_add_io(s->unit->manager->event, &s->event_source, s->inotify_fd, EPOLLIN, handler, s);
-        if (r < 0)
+        if (r < 0) {
+                log_error_errno(r, "Failed to add inotify fd to event loop: %m");
                 goto fail;
+        }
 
         (void) sd_event_source_set_description(s->event_source, "path");