From: Tim Wiederhake <twiederh@redhat.com>
Date: Mon, 1 Feb 2021 12:42:03 +0000 (+0100)
Subject: udevProcessCCW: Initialize variable
X-Git-Tag: v7.1.0-rc1~337
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=795187fe0ca010e240101286fa3d634c128bd419;p=thirdparty%2Flibvirt.git

udevProcessCCW: Initialize variable

`udevGetIntSysfsAttr` does not necessarily write to the third parameter,
even when it returns 0.

This was found by clang-tidy's
"clang-analyzer-core.UndefinedBinaryOperatorResult" check.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/src/node_device/node_device_udev.c b/src/node_device/node_device_udev.c
index fceb135aa5..09048fb23f 100644
--- a/src/node_device/node_device_udev.c
+++ b/src/node_device/node_device_udev.c
@@ -1100,7 +1100,7 @@ static int
 udevProcessCCW(struct udev_device *device,
                virNodeDeviceDefPtr def)
 {
-    int online;
+    int online = 0;
 
     /* process only online devices to keep the list sane */
     if (udevGetIntSysfsAttr(device, "online", &online, 0) < 0 || online != 1)