From: Pawel Baldysiak Date: Wed, 26 Jul 2017 14:41:54 +0000 (+0200) Subject: super1: Always round data offset to 1M X-Git-Tag: mdadm-4.1-rc1~106 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=795bd44ed11aafbed2628ba21216c667371e79a5;p=thirdparty%2Fmdadm.git super1: Always round data offset to 1M Currently if metadata requires more then 1M, data offset will be rounded down to closest MB. This is not correct, since less then required space is reserved. Always round data offset up to multiple of 1M. Signed-off-by: Pawel Baldysiak Signed-off-by: Jes Sorensen --- diff --git a/super1.c b/super1.c index 86ec850d..b15a1c7a 100644 --- a/super1.c +++ b/super1.c @@ -2796,8 +2796,7 @@ static int validate_geometry1(struct supertype *st, int level, headroom >>= 1; data_offset = 12*2 + bmspace + headroom; #define ONE_MEG (2*1024) - if (data_offset > ONE_MEG) - data_offset = (data_offset / ONE_MEG) * ONE_MEG; + data_offset = ROUND_UP(data_offset, ONE_MEG); break; } if (st->data_offset == INVALID_SECTORS)