From: Martti Rannanjärvi <martti.rannanjarvi@dovecot.fi>
Date: Fri, 6 Oct 2017 09:47:06 +0000 (+0300)
Subject: doveadm-mail-crypt: Print existing folder key hash when aborting generate
X-Git-Tag: 2.3.0.rc1~864
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=795c4a5e58d9a8232fad52ca7e045d9d278fdddb;p=thirdparty%2Fdovecot%2Fcore.git

doveadm-mail-crypt: Print existing folder key hash when aborting generate
---

diff --git a/src/plugins/mail-crypt/doveadm-mail-crypt.c b/src/plugins/mail-crypt/doveadm-mail-crypt.c
index 37f197c052..0655236657 100644
--- a/src/plugins/mail-crypt/doveadm-mail-crypt.c
+++ b/src/plugins/mail-crypt/doveadm-mail-crypt.c
@@ -248,7 +248,22 @@ static int mcp_keypair_generate(struct mcp_cmd_context *ctx,
 
 	if ((ret = mail_crypt_box_get_public_key(box, &pair.pub, error_r)) < 0) {
 		ret = -1;
-	} else if (ret == 1 && (!ctx->force || ctx->recrypt_box_keys)) {
+	} else if (ret == 1 && !ctx->force) {
+		i_info("Folder key exists. Use -f to generate a new one");
+		buffer_t *key_id = t_str_new(MAIL_CRYPT_HASH_BUF_SIZE);
+		const char *error;
+		if (!dcrypt_key_id_public(pair.pub,
+					MAIL_CRYPT_KEY_ID_ALGORITHM,
+					key_id, &error)) {
+			i_error("dcrypt_key_id_public() failed: %s",
+				error);
+			return -1;
+		}
+		*pubid_r = p_strdup(ctx->ctx.pool, binary_to_hex(key_id->data,
+								 key_id->used));
+		*pair_r = pair;
+		return 1;
+	} else if (ret == 1 && ctx->recrypt_box_keys) {
 		/* do nothing, because force isn't being used *OR*
 		   we are recrypting box keys and force refers to
 		   user keypair.
@@ -406,7 +421,10 @@ static int mcp_keypair_generate_run(struct doveadm_mail_cmd_context *_ctx,
 			T_BEGIN {
 				mcp_update_shared_keys(box, user, pubid, pair.priv);
 			} T_END;
-			dcrypt_keypair_unref(&pair);
+			if (pair.pub != NULL)
+				dcrypt_key_unref_public(&pair.pub);
+			if (pair.priv != NULL)
+				dcrypt_key_unref_private(&pair.priv);
 			ctx->matched_keys++;
 		}
 		mailbox_free(&box);