From: Stephen Finucane <stephen@that.guru>
Date: Wed, 24 Feb 2021 15:08:45 +0000 (+0000)
Subject: api: do not fetch every patch in a patch detail view 404 (v2)
X-Git-Tag: v3.1.0~96
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79700f321335a2d7c649eb03932797af521942a0;p=thirdparty%2Fpatchwork.git

api: do not fetch every patch in a patch detail view 404 (v2)

Commit 08c5856 fixed an issue whereby a 404 on the aforementioned URL
could result in a large DB query due to DRF attempting to populate the
'related' list box with all patches on the instance. That was
accidentally reverted in commit fe07f30. "Unrevert" this change.

Signed-off-by: Stephen Finucane <stephen@that.guru>
Fixes: fe07f30 ("Remove 'PatchRelationSerializer'")
Closes: #397
---

diff --git a/patchwork/api/patch.py b/patchwork/api/patch.py
index f6cb276d..9d222754 100644
--- a/patchwork/api/patch.py
+++ b/patchwork/api/patch.py
@@ -84,7 +84,8 @@ class PatchListSerializer(BaseHyperlinkedModelSerializer):
     checks = SerializerMethodField()
     tags = SerializerMethodField()
     related = PatchSerializer(
-        source='related.patches', many=True, default=[])
+        source='related.patches', many=True, default=[],
+        style={'base_template': 'input.html'})
 
     def get_web_url(self, instance):
         request = self.context.get('request')