From: Martin Basti <martin.basti@gmail.com>
Date: Sun, 26 Jun 2016 19:55:17 +0000 (+0200)
Subject: Pylint: enable undefined-loop-variable check
X-Git-Tag: v1.15.0~42^2~10
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=797ecaceb7f1b95c51911f987db17ebe32d6ed6d;p=thirdparty%2Fdnspython.git

Pylint: enable undefined-loop-variable check
---

diff --git a/dns/rdata.py b/dns/rdata.py
index 0de9e39e..9e9344d5 100644
--- a/dns/rdata.py
+++ b/dns/rdata.py
@@ -112,8 +112,8 @@ def _truncate_bitmap(what):
 
     for i in xrange(len(what) - 1, -1, -1):
         if what[i] != 0:
-            break
-    return what[0: i + 1]
+            return what[0: i + 1]
+    return what[0:1]
 
 
 class Rdata(object):
diff --git a/dns/resolver.py b/dns/resolver.py
index cf2f54cd..400ed74f 100644
--- a/dns/resolver.py
+++ b/dns/resolver.py
@@ -904,15 +904,15 @@ class Resolver(object):
         all_nxdomain = True
         nxdomain_responses = {}
         start = time.time()
-        for qname in qnames_to_try:
+        for _qname in qnames_to_try:
             if self.cache:
-                answer = self.cache.get((qname, rdtype, rdclass))
+                answer = self.cache.get((_qname, rdtype, rdclass))
                 if answer is not None:
                     if answer.rrset is None and raise_on_no_answer:
                         raise NoAnswer
                     else:
                         return answer
-            request = dns.message.make_query(qname, rdtype, rdclass)
+            request = dns.message.make_query(_qname, rdtype, rdclass)
             if self.keyname is not None:
                 request.use_tsig(self.keyring, self.keyname,
                                  algorithm=self.keyalgorithm)
@@ -1029,7 +1029,7 @@ class Resolver(object):
                     backoff *= 2
                     time.sleep(sleep_time)
             if response.rcode() == dns.rcode.NXDOMAIN:
-                nxdomain_responses[qname] = response
+                nxdomain_responses[_qname] = response
                 continue
             all_nxdomain = False
             break
diff --git a/pylintrc b/pylintrc
index 54e6e750..d17f8f33 100644
--- a/pylintrc
+++ b/pylintrc
@@ -42,7 +42,6 @@ disable=
     round-builtin,
     superfluous-parens,
     too-many-lines,
-    undefined-loop-variable,
     undefined-variable,
     unichr-builtin,
     unicode-builtin,