From: Alan T. DeKok <aland@freeradius.org>
Date: Wed, 8 Apr 2020 15:01:35 +0000 (-0400)
Subject: fix problems introduced in commit 3e7e6970
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=798ef3a9b;p=thirdparty%2Ffreeradius-server.git

fix problems introduced in commit 3e7e6970

u->code != code.  They are different variables with different
meanings.
---

diff --git a/src/modules/rlm_radius/rlm_radius_udp.c b/src/modules/rlm_radius/rlm_radius_udp.c
index 8eced6d0a25..11b53599e6e 100644
--- a/src/modules/rlm_radius/rlm_radius_udp.c
+++ b/src/modules/rlm_radius/rlm_radius_udp.c
@@ -2309,10 +2309,7 @@ static void request_demux(fr_trunk_connection_t *tconn, fr_connection_t *conn, U
 		 *	automatically result in it the parent request
 		 *	returning an ok/fail packet code.
 		 */
-		switch (u->code) {
-		case FR_CODE_ACCESS_REQUEST:
-		case FR_CODE_ACCESS_CHALLENGE:
-		{
+		if ((u->code == FR_CODE_ACCESS_REQUEST) && (code == FR_CODE_ACCESS_CHALLENGE)) {
 			VALUE_PAIR	*vp;
 
 			vp = fr_pair_find_by_da(request->reply->vps, attr_packet_type, TAG_ANY);
@@ -2322,11 +2319,6 @@ static void request_demux(fr_trunk_connection_t *tconn, fr_connection_t *conn, U
 				fr_pair_add(&request->reply->vps, vp);
 			}
 		}
-			break;
-
-		default:
-			break;
-		}
 
 		/*
 		 *	Delete Proxy-State attributes from the reply.