From: Peter van Dijk <peter.van.dijk@powerdns.com>
Date: Wed, 6 Jan 2021 16:09:52 +0000 (+0100)
Subject: remotebackend: use 0 for denoting unknown serial which is uint32_t
X-Git-Tag: rec-4.5.0-alpha1~34^2~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79989810021b4f08b1365bca9b1fc16c6d9aad8e;p=thirdparty%2Fpdns.git

remotebackend: use 0 for denoting unknown serial which is uint32_t

remotebackend.cc:610:51: runtime error: -1 is outside the range of representable values of type 'unsigned int'
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior remotebackend.cc:610:51 in
---

diff --git a/modules/remotebackend/remotebackend.cc b/modules/remotebackend/remotebackend.cc
index 220b518f0e..7fb4d015f8 100644
--- a/modules/remotebackend/remotebackend.cc
+++ b/modules/remotebackend/remotebackend.cc
@@ -607,7 +607,7 @@ void RemoteBackend::parseDomainInfo(const Json &obj, DomainInfo &di)
    for(const auto& master: obj["masters"].array_items())
      di.masters.push_back(ComboAddress(master.string_value(), 53));
 
-   di.notified_serial = static_cast<unsigned int>(doubleFromJson(obj, "notified_serial", -1));
+   di.notified_serial = static_cast<unsigned int>(doubleFromJson(obj, "notified_serial", 0));
    di.serial = static_cast<unsigned int>(obj["serial"].number_value());
    di.last_check = static_cast<time_t>(obj["last_check"].number_value());