From: Peter Krempa Date: Tue, 13 Sep 2011 15:16:45 +0000 (+0200) Subject: virsh: Use old API if remote libvirtd does not support new X-Git-Tag: v0.9.5-rc2~7 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=799912fa05b8c3aa37bd04c57b196755f3f70552;p=thirdparty%2Flibvirt.git virsh: Use old API if remote libvirtd does not support new Commit ffe28ab74b821c916ec4ba8efb5c992454e4bd24 introduced regression while communicating with older libvirtd command 'domblkstat' used the new API and did not check for VIR_ERR_RPC error code signalling the remote server does not support this API and did not fall back to older API. Thereafter 'domblkstat' ended with "error: unknown procedure: 243". --- diff --git a/tools/virsh.c b/tools/virsh.c index 3b060bfdc4..430168c026 100644 --- a/tools/virsh.c +++ b/tools/virsh.c @@ -1090,7 +1090,8 @@ cmdDomblkstat (vshControl *ctl, const vshCmd *cmd) * then. */ if (rc < 0) { - if (last_error->code != VIR_ERR_NO_SUPPORT) { + if (last_error->code != VIR_ERR_NO_SUPPORT && + last_error->code != VIR_ERR_RPC) { virshReportError(ctl); goto cleanup; } else {