From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Mon, 12 Oct 2020 15:27:49 +0000 (+0200)
Subject: Make PacketReader accept a pdns_string_view
X-Git-Tag: rec-4.5.0-alpha1~19^2~9
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79a0ad01601e0e695b1f3e0c3db380d94126efc5;p=thirdparty%2Fpdns.git

Make PacketReader accept a pdns_string_view
---

diff --git a/pdns/dnsparser.cc b/pdns/dnsparser.cc
index ee45864ad6..f8755b4934 100644
--- a/pdns/dnsparser.cc
+++ b/pdns/dnsparser.cc
@@ -212,7 +212,7 @@ DNSResourceRecord DNSResourceRecord::fromWire(const DNSRecord& d) {
   return rr;
 }
 
-void MOADNSParser::init(bool query, const std::string& packet)
+void MOADNSParser::init(bool query, const pdns_string_view& packet)
 {
   if (packet.size() < sizeof(dnsheader))
     throw MOADNSException("Packet shorter than minimal header");
diff --git a/pdns/dnsparser.hh b/pdns/dnsparser.hh
index 0291195284..fc39aaeb95 100644
--- a/pdns/dnsparser.hh
+++ b/pdns/dnsparser.hh
@@ -399,7 +399,7 @@ public:
   //! Parse from a pointer and length
   MOADNSParser(bool query, const char *packet, unsigned int len) : d_tsigPos(0)
   {
-    init(query, std::string(packet, len));
+    init(query, pdns_string_view(packet, len));
   }
 
   DNSName d_qname;
@@ -420,7 +420,7 @@ public:
   bool hasEDNS() const;
 
 private:
-  void init(bool query, const std::string& packet);
+  void init(bool query, const pdns_string_view& packet);
   uint16_t d_tsigPos;
 };