From: Pádraig Brady <P@draigBrady.com>
Date: Fri, 20 Mar 2015 01:13:17 +0000 (+0000)
Subject: maint: fix wildcard quoting in sc_tests_executable
X-Git-Tag: v8.24~102
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79e27fd67ed2c23b9cf01c42e3dae741559eb03c;p=thirdparty%2Fcoreutils.git

maint: fix wildcard quoting in sc_tests_executable

* cfg.mk (sc_tests_executable): If there are files with
$TEST_EXTENSIONS in the current directory, then the
lack of quoting of the $test_extensions_rx contents
could result in globbing and an inconsequential run.
find(1) produces warnings only with more than one expansion.
---

diff --git a/cfg.mk b/cfg.mk
index d65af2726e..a3b0e8e1d7 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -116,10 +116,9 @@ sc_tests_list_consistency:
 
 # Ensure that all version-controlled test scripts are executable.
 sc_tests_executable:
-	@test_extensions_rx=`echo $(TEST_EXTENSIONS)			\
-	  | sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
-	find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
-	  | sed -e "s/^/$(ME): Please make test executable: /" | grep . \
+	@test_extensions_rx=`printf -- "-name '*%s' " $(TEST_EXTENSIONS)`;\
+	find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print	  \
+	  | sed -e "s/^/$(ME): Please make test executable: /" | grep .	  \
 	    && exit 1; :
 
 # Ensure all gnulib patches apply cleanly