From: Pablo Neira Ayuso <pablo@netfilter.org>
Date: Fri, 15 Apr 2016 10:29:42 +0000 (+0200)
Subject: rule: fix leaks in NFTNL_RULE_USERDATA
X-Git-Tag: libnftnl-1.0.6~15
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=79f475c99b83775fdb9ec331eef85c94e80a3449;p=thirdparty%2Flibnftnl.git

rule: fix leaks in NFTNL_RULE_USERDATA

Fix leaks in nftnl_rule_free() and nftnl_rule_set_data().

Reported-by: Carlos Falgueras García <carlosfg@riseup.net>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/src/rule.c b/src/rule.c
index 3a32bf69..9c091271 100644
--- a/src/rule.c
+++ b/src/rule.c
@@ -75,6 +75,8 @@ void nftnl_rule_free(struct nftnl_rule *r)
 		xfree(r->table);
 	if (r->chain != NULL)
 		xfree(r->chain);
+	if (r->user.data != NULL)
+		xfree(r->user.data);
 
 	xfree(r);
 }
@@ -162,6 +164,9 @@ void nftnl_rule_set_data(struct nftnl_rule *r, uint16_t attr,
 		r->position = *((uint64_t *)data);
 		break;
 	case NFTNL_RULE_USERDATA:
+		if (r->user.data != NULL)
+			xfree(r->user.data);
+
 		r->user.data = (void *)data;
 		r->user.len = data_len;
 		break;