From: Andreas Schneider Date: Wed, 9 May 2018 15:35:45 +0000 (+0200) Subject: s4:torture: Use strlcpy() in gen_name() X-Git-Tag: ldb-1.4.0~129 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a00d90d668f53914ffe035c41a5e79e60b51521;p=thirdparty%2Fsamba.git s4:torture: Use strlcpy() in gen_name() ../source4/torture/basic/mangle_test.c: In function ‘gen_name’: ../source4/torture/basic/mangle_test.c:148:3: error: ‘strncpy’ output truncated before terminating nul copying 5 bytes from a string of the same length [-Werror=stringop-truncation] strncpy(p, "ABCDE", 5); ^~~~~~~~~~~~~~~~~~~~~~ BUG: https://bugzilla.samba.org/show_bug.cgi?id=13437 Signed-off-by: Andreas Schneider Reviewed-by: Guenther Deschner --- diff --git a/source4/torture/basic/mangle_test.c b/source4/torture/basic/mangle_test.c index 0b7d696e677..df12b3ce821 100644 --- a/source4/torture/basic/mangle_test.c +++ b/source4/torture/basic/mangle_test.c @@ -145,7 +145,7 @@ static char *gen_name(TALLOC_CTX *mem_ctx) /* and a medium probability of a common lead string */ if ((len > 5) && (random() % 10 == 0)) { - strncpy(p, "ABCDE", 5); + strlcpy(p, "ABCDE", 6); } /* and a high probability of a good extension length */