From: Phil Sutter Date: Thu, 11 Aug 2016 23:33:38 +0000 (+0200) Subject: src: Avoid returning uninitialized data X-Git-Tag: libnftnl-1.0.7~54 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a150cacc1754f66525f0e87b14b35fbc2a6338e;p=thirdparty%2Flibnftnl.git src: Avoid returning uninitialized data Although the 'err' pointer should be interesting for users only if the parser returned non-zero, having it point to uninitialized data is generally a bad thing. Signed-off-by: Phil Sutter Signed-off-by: Pablo Neira Ayuso --- diff --git a/src/chain.c b/src/chain.c index ff59f7f7..dfe0cf23 100644 --- a/src/chain.c +++ b/src/chain.c @@ -816,7 +816,7 @@ static int nftnl_chain_do_parse(struct nftnl_chain *c, enum nftnl_parse_type typ enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/rule.c b/src/rule.c index dada00e1..8aeefbe1 100644 --- a/src/rule.c +++ b/src/rule.c @@ -700,7 +700,7 @@ static int nftnl_rule_do_parse(struct nftnl_rule *r, enum nftnl_parse_type type, enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/set.c b/src/set.c index 7a41e8ca..47b6ef46 100644 --- a/src/set.c +++ b/src/set.c @@ -781,7 +781,7 @@ static int nftnl_set_do_parse(struct nftnl_set *s, enum nftnl_parse_type type, enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: diff --git a/src/table.c b/src/table.c index bb467169..845fd681 100644 --- a/src/table.c +++ b/src/table.c @@ -360,7 +360,7 @@ static int nftnl_table_do_parse(struct nftnl_table *t, enum nftnl_parse_type typ enum nftnl_parse_input input) { int ret; - struct nftnl_parse_err perr; + struct nftnl_parse_err perr = {}; switch (type) { case NFTNL_PARSE_XML: