From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 17 Mar 2020 14:31:12 +0000 (+0100)
Subject: qemuBlockBitmapsHandleCommitFinish: Use proper variable to iterate
X-Git-Tag: v6.2.0-rc1~145
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a16318855811ac4ae55d30b77969528099fd180;p=thirdparty%2Flibvirt.git

qemuBlockBitmapsHandleCommitFinish: Use proper variable to iterate

The function repeatedly checked the first element rather than iterating
through the array.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
---

diff --git a/src/qemu/qemu_block.c b/src/qemu/qemu_block.c
index 115682c39d..f95ebb6fa7 100644
--- a/src/qemu/qemu_block.c
+++ b/src/qemu/qemu_block.c
@@ -3177,7 +3177,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePtr topsrc,
                     char **disabledbitmaps;
 
                     for (disabledbitmaps = disabledBitmapsBase; *disabledbitmaps; disabledbitmaps++) {
-                        if (STREQ(*disabledBitmapsBase, bitmap->name)) {
+                        if (STREQ(*disabledbitmaps, bitmap->name)) {
                             bitmapdata = g_new0(struct qemuBlockBitmapsHandleCommitData, 1);
 
                             bitmapdata->create = false;