From: Matthew Crumley <email@matthewcrumley.com>
Date: Sun, 18 Oct 2020 03:52:56 +0000 (-0400)
Subject: Fix Maximum call stack size exception in _computeLabelSizes (#7906)
X-Git-Tag: v3.0.0-beta.5~39
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a35f3cb3e4ede8cf0d32e1bb2eef83a31e2e664;p=thirdparty%2FChart.js.git

Fix Maximum call stack size exception in _computeLabelSizes (#7906)

Issue #7881
---

diff --git a/src/core/core.scale.js b/src/core/core.scale.js
index 82433fc19..06c50395c 100644
--- a/src/core/core.scale.js
+++ b/src/core/core.scale.js
@@ -894,6 +894,8 @@ export default class Scale extends Element {
 		const widths = [];
 		const heights = [];
 		const offsets = [];
+		let widestLabelSize = 0;
+		let highestLabelSize = 0;
 		let ticks = me.ticks;
 		if (sampleSize < ticks.length) {
 			ticks = sample(ticks, sampleSize);
@@ -926,11 +928,13 @@ export default class Scale extends Element {
 			widths.push(width);
 			heights.push(height);
 			offsets.push(lineHeight / 2);
+			widestLabelSize = Math.max(width, widestLabelSize);
+			highestLabelSize = Math.max(height, highestLabelSize);
 		}
 		garbageCollect(caches, length);
 
-		const widest = widths.indexOf(Math.max.apply(null, widths));
-		const highest = heights.indexOf(Math.max.apply(null, heights));
+		const widest = widths.indexOf(widestLabelSize);
+		const highest = heights.indexOf(highestLabelSize);
 
 		function valueAt(idx) {
 			return {