From: Kunal Marwaha Date: Tue, 29 Nov 2016 06:57:45 +0000 (-0800) Subject: Add accessor function to isValid X-Git-Tag: 2.18.0~45^2~9 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a36cb42187f15f08782807e33ee50de9ab24245;p=thirdparty%2Fmoment.git Add accessor function to isValid --- diff --git a/src/lib/duration/constructor.js b/src/lib/duration/constructor.js index 042d38f3e..994adab4f 100644 --- a/src/lib/duration/constructor.js +++ b/src/lib/duration/constructor.js @@ -6,6 +6,7 @@ export function Duration (duration) { var normalizedInput = normalizeObjectUnits(duration); this._isValid = isDurationValid(normalizedInput); + this.isValid = () => this._isValid; var years = this._isValid && normalizedInput.year || 0, quarters = this._isValid && normalizedInput.quarter || 0, diff --git a/src/test/moment/duration.js b/src/test/moment/duration.js index 3a60756de..3b8b493f8 100644 --- a/src/test/moment/duration.js +++ b/src/test/moment/duration.js @@ -53,17 +53,17 @@ test('milliseconds instantiation', function (assert) { test('undefined instantiation', function (assert) { assert.equal(moment.duration(undefined).milliseconds(), 0, 'milliseconds'); - assert.equal(moment.duration(undefined)._isValid, true, '_isValid'); + assert.equal(moment.duration(undefined).isValid(), true, '_isValid'); }); test('null instantiation', function (assert) { assert.equal(moment.duration(null).milliseconds(), 0, 'milliseconds'); - assert.equal(moment.duration(null)._isValid, true, '_isValid'); + assert.equal(moment.duration(null).isValid(), true, '_isValid'); }); test('NaN instantiation', function (assert) { assert.equal(moment.duration(NaN).milliseconds(), 0, 'milliseconds'); - assert.equal(moment.duration(NaN)._isValid, false, '_isValid'); + assert.equal(moment.duration(NaN).isValid(), false, '_isValid'); }); test('instantiation by type', function (assert) {