From: Victor Julien <vjulien@oisf.net>
Date: Wed, 25 Jan 2023 11:29:09 +0000 (+0100)
Subject: streaming: fix possible use after free
X-Git-Tag: suricata-7.0.0-rc1~70
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a47eabf8258a2869c25e18b5538a6d90765589a;p=thirdparty%2Fsuricata.git

streaming: fix possible use after free

Don't use ptr after freeing it. Reported by Coverity Scan.
---

diff --git a/src/util-streaming-buffer.c b/src/util-streaming-buffer.c
index b704a62ef9..bcbb288e36 100644
--- a/src/util-streaming-buffer.c
+++ b/src/util-streaming-buffer.c
@@ -1178,8 +1178,6 @@ static StreamingBufferRegion *BufferInsertAtRegionConsolidate(StreamingBuffer *s
 
         if (r == src_end)
             break;
-
-        prev = r;
         r = next;
     }