From: G.E <gregory.economou@vectorcamp.gr>
Date: Mon, 20 May 2024 13:35:58 +0000 (+0300)
Subject: undo that one, it breaks
X-Git-Tag: vectorscan/5.4.12^2~34^2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a5f271abe837decf533dc917b09638f173b265d;p=thirdparty%2Fvectorscan.git

undo that one, it breaks
---

diff --git a/src/fdr/fdr_compile.cpp b/src/fdr/fdr_compile.cpp
index 3703c872..0edb3a94 100644
--- a/src/fdr/fdr_compile.cpp
+++ b/src/fdr/fdr_compile.cpp
@@ -135,10 +135,10 @@ void FDRCompiler::createInitialState(FDR *fdr) {
         // Find the minimum length for the literals in this bucket.
         const vector<LiteralIndex> &bucket_lits = bucketToLits[b];
         u32 min_len = ~0U;
-        auto mlit = [lits=lits](const LiteralIndex &m, const LiteralIndex &n) {
-            return verify_u32(lits[m].s.length()) < verify_u32(lits[n].s.length()); };
-        auto minel = std::min_element(bucket_lits.begin(), bucket_lits.end(), mlit);
-        min_len = min(min_len, verify_u32(lits[*minel].s.length()));
+        for (const LiteralIndex &lit_idx : bucket_lits) {		
+            // cppcheck-suppress useStlAlgorithm		
+            min_len = min(min_len, verify_u32(lits[lit_idx].s.length()));		
+        }
 
         DEBUG_PRINTF("bucket %u has min_len=%u\n", b, min_len);
         assert(min_len);