From: Jim Meyering <meyering@redhat.com>
Date: Sun, 24 Jul 2011 13:50:36 +0000 (+0200)
Subject: docs: improve the prose describing _AC_CHECK_TYPE_NEW_BODY
X-Git-Tag: v2.68b~58
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a615729c9c56a3608ec0224a67f21d23ea6b3ad;p=thirdparty%2Fautoconf.git

docs: improve the prose describing _AC_CHECK_TYPE_NEW_BODY

* lib/autoconf/types.m4 (_AC_CHECK_TYPE_NEW_BODY): Improve prose.
---

diff --git a/ChangeLog b/ChangeLog
index 1e17e609..219176f8 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-07-24  Jim Meyering  <meyering@redhat.com>
+
+	docs: improve the prose describing _AC_CHECK_TYPE_NEW_BODY
+	* lib/autoconf/types.m4 (_AC_CHECK_TYPE_NEW_BODY): Improve prose.
+
 2011-08-31  Paul Eggert  <eggert@cs.ucla.edu>
 
 	AC_C_CONST: don't reject gcc -Werror -Wall
diff --git a/lib/autoconf/types.m4 b/lib/autoconf/types.m4
index c47884c5..72093e99 100644
--- a/lib/autoconf/types.m4
+++ b/lib/autoconf/types.m4
@@ -80,15 +80,15 @@
 #	  int foo (TYPE param);
 #
 # but of course you soon realize this does not make it with K&R
-# compilers.  And by no ways you want to
+# compilers.  And by no means do you want to use this:
 #
 #	  int foo (param)
 #	    TYPE param
 #	  { ; }
 #
-# since this time it's C++ who is not happy.
+# since C++ would complain loudly.
 #
-# Don't even think of the return type of a function, since K&R cries
+# Don't even think of using a function return type, since K&R cries
 # there too.  So you start thinking of declaring a *pointer* to this TYPE:
 #
 #	  TYPE *p;
@@ -101,14 +101,16 @@
 #
 #	  sizeof (TYPE);
 #
-# But this succeeds if TYPE is a variable: you get the size of the
-# variable's type!!!
+# That is great, but has one drawback: it succeeds when TYPE happens
+# to be a variable: you'd get the size of the variable's type.
+# Obviously, we must not accept a variable in place of a type name.
 #
-# So, to filter out the last possibility, you try this too:
+# So, to filter out the last possibility, we will require that this fail:
 #
 #	  sizeof ((TYPE));
 #
-# This fails if TYPE is a type, but succeeds if TYPE is actually a variable.
+# This evokes a syntax error when TYPE is a type, but succeeds if TYPE
+# is actually a variable.
 #
 # Also note that we use
 #