From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 30 May 2017 01:30:43 +0000 (-0400)
Subject: CID 1317340: Use array initialiser instead
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a6e2cb02d796129f9bb88fc9ffb028b23eee99f;p=thirdparty%2Ffreeradius-server.git

CID 1317340: Use array initialiser instead
---

diff --git a/src/lib/util/misc.c b/src/lib/util/misc.c
index 6876b818c9d..cb39c8d04dc 100644
--- a/src/lib/util/misc.c
+++ b/src/lib/util/misc.c
@@ -743,23 +743,18 @@ ssize_t fr_utf8_to_ucs2(uint8_t *out, size_t outlen, char const *in, size_t inle
  */
 size_t fr_snprint_uint128(char *out, size_t outlen, uint128_t const num)
 {
-	char buff[128 / 3 + 1 + 1];
+	char buff[128 / 3 + 1 + 1] = { '0' };
 	uint64_t n[2];
 	char *p = buff;
 	int i;
 #ifndef WORDS_BIGENDIAN
-	const size_t l = 0;
-	const size_t h = 1;
+	size_t const l = 0;
+	size_t const h = 1;
 #else
-	const size_t l = 1;
-	const size_t h = 0;
+	size_t const l = 1;
+	size_t const h = 0;
 #endif
 
-	/*
-	 *	We use 0x30, and not '0', because '0' makes Coverity
-	 *	think we screwed up.
-	 */
-	memset(buff, 0x30, sizeof(buff) - 1);
 	buff[sizeof(buff) - 1] = '\0';
 
 	memcpy(n, &num, sizeof(n));