From: Remi Gacogne <remi.gacogne@powerdns.com>
Date: Fri, 25 Jul 2025 10:05:12 +0000 (+0200)
Subject: dnsdist: Fix CodeQL warnings
X-Git-Tag: rec-5.4.0-alpha1~224^2~8
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a787eb530f1f8ba4fb417a9bacff0090b172314;p=thirdparty%2Fpdns.git

dnsdist: Fix CodeQL warnings

Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
---

diff --git a/pdns/dnsdistdist/dnsdist-lbpolicies.cc b/pdns/dnsdistdist/dnsdist-lbpolicies.cc
index 4cdc57b023..56c6fcda20 100644
--- a/pdns/dnsdistdist/dnsdist-lbpolicies.cc
+++ b/pdns/dnsdistdist/dnsdist-lbpolicies.cc
@@ -345,7 +345,7 @@ void setPoolPolicy(const string& poolName, std::shared_ptr<ServerPolicy> policy)
   }
 
   dnsdist::configuration::updateRuntimeConfiguration([&poolName, &policy](dnsdist::configuration::RuntimeConfiguration& config) {
-    auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool());
+    auto [poolIt, _] = config.d_pools.emplace(poolName, ServerPool());
     poolIt->second.policy = std::move(policy);
   });
 }
@@ -359,7 +359,7 @@ void addServerToPool(const string& poolName, std::shared_ptr<DownstreamState> se
   }
 
   dnsdist::configuration::updateRuntimeConfiguration([&poolName, &server](dnsdist::configuration::RuntimeConfiguration& config) {
-    auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool());
+    auto [poolIt, _] = config.d_pools.emplace(poolName, ServerPool());
     poolIt->second.addServer(server);
   });
 }
@@ -374,7 +374,7 @@ void removeServerFromPool(const string& poolName, std::shared_ptr<DownstreamStat
   }
 
   dnsdist::configuration::updateRuntimeConfiguration([&poolName, &server](dnsdist::configuration::RuntimeConfiguration& config) {
-    auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool());
+    auto [poolIt, _] = config.d_pools.emplace(poolName, ServerPool());
     poolIt->second.removeServer(server);
   });
 }
diff --git a/pdns/dnsdistdist/dnsdist-lua.cc b/pdns/dnsdistdist/dnsdist-lua.cc
index f84fc4af61..422dcf4032 100644
--- a/pdns/dnsdistdist/dnsdist-lua.cc
+++ b/pdns/dnsdistdist/dnsdist-lua.cc
@@ -1682,7 +1682,7 @@ static void setupLuaConfig(LuaContext& luaCtx, bool client, bool configCheck)
     }
     bool created = false;
     dnsdist::configuration::updateRuntimeConfiguration([&poolName, &created](dnsdist::configuration::RuntimeConfiguration& config) {
-      auto [poolIt, inserted] = config.d_pools.emplace(poolName, ServerPool());
+      auto [_, inserted] = config.d_pools.emplace(poolName, ServerPool());
       created = inserted;
     });