From: Theodore Ts'o <tytso@mit.edu>
Date: Tue, 31 Jan 2017 20:29:57 +0000 (-0500)
Subject: libext2fs: fix memory leaks in ext2fs_xattr_set()
X-Git-Tag: 1.43.4~14
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a82e706208f2eca52781d4970f90f8e1af9a25e;p=thirdparty%2Fe2fsprogs.git

libext2fs: fix memory leaks in ext2fs_xattr_set()

Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/lib/ext2fs/ext_attr.c b/lib/ext2fs/ext_attr.c
index 0314f9f79..ce2f48fef 100644
--- a/lib/ext2fs/ext_attr.c
+++ b/lib/ext2fs/ext_attr.c
@@ -1186,17 +1186,17 @@ errcode_t ext2fs_xattr_set(struct ext2_xattr_handle *handle,
 	/* Expand array, append slot */
 	err = ext2fs_xattrs_expand(handle, 4);
 	if (err)
-		return err;
+		goto errout;
 
 	x = handle->attrs + handle->length - 4;
 	err = ext2fs_get_mem(strlen(key) + 1, &x->name);
 	if (err)
-		return err;
+		goto errout;
 	strcpy(x->name, key);
 
 	err = ext2fs_get_mem(value_len, &x->value);
 	if (err)
-		return err;
+		goto errout;
 	memcpy(x->value, value, value_len);
 	x->value_len = value_len;
 	handle->dirty = 1;