From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 11 Aug 2024 19:33:13 +0000 (-0400)
Subject: don't smash the authentication vector
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a87bee2dbb4b4559511b597f0d6f2a0fd8455af;p=thirdparty%2Ffreeradius-server.git

don't smash the authentication vector
---

diff --git a/src/protocols/radius/packet.c b/src/protocols/radius/packet.c
index 5c41f797379..5d69f394d3e 100644
--- a/src/protocols/radius/packet.c
+++ b/src/protocols/radius/packet.c
@@ -166,16 +166,6 @@ int fr_packet_sign(fr_packet_t *packet, fr_packet_t const *original,
 {
 	int ret;
 
-	/*
-	 *	Copy the random vector to the packet.  Other packet
-	 *	codes have the Request Authenticator be the packet
-	 *	signature.
-	 */
-	if ((packet->code == FR_RADIUS_CODE_ACCESS_REQUEST) ||
-	    (packet->code == FR_RADIUS_CODE_STATUS_SERVER)) {
-		memcpy(packet->data + 4, packet->vector, sizeof(packet->vector));
-	}
-
 	ret = fr_radius_sign(packet->data, original ? original->data + 4 : NULL,
 			       (uint8_t const *) secret, talloc_array_length(secret) - 1);
 	if (ret < 0) return ret;