From: Tomas Mraz Date: Fri, 20 May 2022 14:27:51 +0000 (+0200) Subject: Fix regression in default key length for Blowfish CFB and OFB ciphers X-Git-Tag: openssl-3.2.0-alpha1~2631 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7a9e93dda58118c0fb1bade8fe915306b845325b;p=thirdparty%2Fopenssl.git Fix regression in default key length for Blowfish CFB and OFB ciphers Fixes #18359 Reviewed-by: Matt Caswell Reviewed-by: Richard Levitte (Merged from https://github.com/openssl/openssl/pull/18362) --- diff --git a/providers/implementations/ciphers/cipher_blowfish.c b/providers/implementations/ciphers/cipher_blowfish.c index 9566f044a4e..e3b08ddbe4d 100644 --- a/providers/implementations/ciphers/cipher_blowfish.c +++ b/providers/implementations/ciphers/cipher_blowfish.c @@ -55,6 +55,6 @@ IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, ecb, ECB, BF_FLAGS, 128, 64, 0, /* bf_cbc_functions */ IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, cbc, CBC, BF_FLAGS, 128, 64, 64, block) /* bf_ofb_functions */ -IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, ofb64, OFB, BF_FLAGS, 64, 8, 64, stream) +IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, ofb64, OFB, BF_FLAGS, 128, 8, 64, stream) /* bf_cfb_functions */ -IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, cfb64, CFB, BF_FLAGS, 64, 8, 64, stream) +IMPLEMENT_var_keylen_cipher(blowfish, BLOWFISH, cfb64, CFB, BF_FLAGS, 128, 8, 64, stream) diff --git a/providers/implementations/include/prov/implementations.h b/providers/implementations/include/prov/implementations.h index d7b591cf725..57400282875 100644 --- a/providers/implementations/include/prov/implementations.h +++ b/providers/implementations/include/prov/implementations.h @@ -156,8 +156,8 @@ extern const OSSL_DISPATCH ossl_camellia128ctr_functions[]; #ifndef OPENSSL_NO_BF extern const OSSL_DISPATCH ossl_blowfish128ecb_functions[]; extern const OSSL_DISPATCH ossl_blowfish128cbc_functions[]; -extern const OSSL_DISPATCH ossl_blowfish64ofb64_functions[]; -extern const OSSL_DISPATCH ossl_blowfish64cfb64_functions[]; +extern const OSSL_DISPATCH ossl_blowfish128ofb64_functions[]; +extern const OSSL_DISPATCH ossl_blowfish128cfb64_functions[]; #endif /* OPENSSL_NO_BF */ #ifndef OPENSSL_NO_IDEA extern const OSSL_DISPATCH ossl_idea128ecb_functions[]; diff --git a/providers/legacyprov.c b/providers/legacyprov.c index ddfd555910a..1280ca43132 100644 --- a/providers/legacyprov.c +++ b/providers/legacyprov.c @@ -112,8 +112,8 @@ static const OSSL_ALGORITHM legacy_ciphers[] = { #ifndef OPENSSL_NO_BF ALG(PROV_NAMES_BF_ECB, ossl_blowfish128ecb_functions), ALG(PROV_NAMES_BF_CBC, ossl_blowfish128cbc_functions), - ALG(PROV_NAMES_BF_OFB, ossl_blowfish64ofb64_functions), - ALG(PROV_NAMES_BF_CFB, ossl_blowfish64cfb64_functions), + ALG(PROV_NAMES_BF_OFB, ossl_blowfish128ofb64_functions), + ALG(PROV_NAMES_BF_CFB, ossl_blowfish128cfb64_functions), #endif /* OPENSSL_NO_BF */ #ifndef OPENSSL_NO_IDEA ALG(PROV_NAMES_IDEA_ECB, ossl_idea128ecb_functions),