From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Wed, 6 Mar 2024 21:00:51 +0000 (-0600)
Subject: No need for context
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7ab01789937e0271452306aaf2c513c9bea8069c;p=thirdparty%2Ffreeradius-server.git

No need for context
---

diff --git a/src/bin/radclient-ng.c b/src/bin/radclient-ng.c
index c72afe8ec08..2b765ce99b5 100644
--- a/src/bin/radclient-ng.c
+++ b/src/bin/radclient-ng.c
@@ -1037,7 +1037,7 @@ static int recv_one_packet(fr_time_delta_t wait_time)
 			RDEBUG("%s: Response passed filter", request->name);
 			stats.passed++;
 		} else {
-			fr_pair_validate_debug(request, failed);
+			fr_pair_validate_debug(failed);
 			REDEBUG("%s: Response for failed filter", request->name);
 			stats.failed++;
 		}
diff --git a/src/bin/radclient.c b/src/bin/radclient.c
index b746d16c1a6..7dea8db2837 100644
--- a/src/bin/radclient.c
+++ b/src/bin/radclient.c
@@ -1220,7 +1220,7 @@ static int recv_coa_packet(fr_time_delta_t wait_time)
 			RDEBUG("%s: CoA request passed filter", request->name);
 			stats.passed++;
 		} else {
-			fr_pair_validate_debug(request, failed);
+			fr_pair_validate_debug(failed);
 			REDEBUG("%s: CoA Request for failed filter", request->name);
 			stats.failed++;
 		}
@@ -1414,7 +1414,7 @@ static int recv_one_packet(fr_time_delta_t wait_time)
 			RDEBUG("%s: Response passed filter", request->name);
 			stats.passed++;
 		} else {
-			fr_pair_validate_debug(request, failed);
+			fr_pair_validate_debug(failed);
 			REDEBUG("%s: Response for failed filter", request->name);
 			stats.failed++;
 		}
diff --git a/src/bin/unit_test_module.c b/src/bin/unit_test_module.c
index 99c4c92aff9..d916d8f01a5 100644
--- a/src/bin/unit_test_module.c
+++ b/src/bin/unit_test_module.c
@@ -1148,7 +1148,7 @@ int main(int argc, char *argv[])
 
 
 		if (!fr_pair_validate(failed, &filter_vps, &request->reply_pairs)) {
-			fr_pair_validate_debug(request, failed);
+			fr_pair_validate_debug(failed);
 			fr_perror("Output file %s does not match attributes in filter %s",
 				  output_file ? output_file : "-", filter_file);
 			ret = EXIT_FAILURE;
diff --git a/src/lib/util/pair.c b/src/lib/util/pair.c
index 9c912d1cea0..a09e11c2792 100644
--- a/src/lib/util/pair.c
+++ b/src/lib/util/pair.c
@@ -2056,7 +2056,7 @@ int fr_pair_list_cmp(fr_pair_list_t const *a, fr_pair_list_t const *b)
  * @param ctx a hack until we have thread specific talloc contexts.
  * @param failed pair of attributes which didn't match.
  */
-void fr_pair_validate_debug(TALLOC_CTX *ctx, fr_pair_t const *failed[2])
+void fr_pair_validate_debug(fr_pair_t const *failed[2])
 {
 	fr_pair_t const *filter = failed[0];
 	fr_pair_t const *list = failed[1];
diff --git a/src/lib/util/pair.h b/src/lib/util/pair.h
index 84e96db4bfa..2b0b8def7ea 100644
--- a/src/lib/util/pair.h
+++ b/src/lib/util/pair.h
@@ -673,7 +673,7 @@ int		fr_pair_cmp(fr_pair_t const *a, fr_pair_t const *b);
 int		fr_pair_list_cmp(fr_pair_list_t const *a, fr_pair_list_t const *b) CC_HINT(nonnull);
 
 /* Filtering */
-void		fr_pair_validate_debug(TALLOC_CTX *ctx, fr_pair_t const *failed[2]) CC_HINT(nonnull(2));
+void		fr_pair_validate_debug(fr_pair_t const *failed[2]) CC_HINT(nonnull(2));
 
 bool		fr_pair_validate(fr_pair_t const *failed[2], fr_pair_list_t *filter,
 				 fr_pair_list_t *list) CC_HINT(nonnull(2,3));