From: Michael Altizer (mialtize) <mialtize@cisco.com>
Date: Fri, 10 Apr 2020 21:40:13 +0000 (+0000)
Subject: Merge pull request #2150 in SNORT/snort3 from ~MIALTIZE/snort3:kill_inspectordata... 
X-Git-Tag: 3.0.1-2~24
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7abd1f0dbd5b97480c6b1287af5eaf91b22d83f2;p=thirdparty%2Fsnort3.git

Merge pull request #2150 in SNORT/snort3 from ~MIALTIZE/snort3:kill_inspectordata to master

Squashed commit of the following:

commit 55c887b65e3e21401ec64eb80b647ea5dfb6b4f5
Author: Michael Altizer <mialtize@cisco.com>
Date:   Fri Apr 10 12:56:52 2020 -0400

    framework: Remove unused InspectorData template

    Reimplement the only prior user (FtpClient) without the template.
---

diff --git a/src/framework/inspector.h b/src/framework/inspector.h
index d7b4e4ffb..d6dffc84c 100644
--- a/src/framework/inspector.h
+++ b/src/framework/inspector.h
@@ -150,22 +150,6 @@ private:
     SnortProtocolId snort_protocol_id;
 };
 
-template <typename T>
-class InspectorData : public Inspector
-{
-public:
-    InspectorData(T* t)
-    { data = t; }
-
-    ~InspectorData() override
-    { delete data; }
-
-    void show(SnortConfig*) override { }
-    void eval(Packet*) override { }
-
-    T* data;
-};
-
 // at present there is no sequencing among like types except that appid
 // is always first among controls.
 
diff --git a/src/service_inspectors/ftp_telnet/ftp.cc b/src/service_inspectors/ftp_telnet/ftp.cc
index 4715fd659..6ece3faa0 100644
--- a/src/service_inspectors/ftp_telnet/ftp.cc
+++ b/src/service_inspectors/ftp_telnet/ftp.cc
@@ -186,13 +186,24 @@ static int snort_ftp(Packet* p)
 // class stuff
 //-------------------------------------------------------------------------
 
-typedef InspectorData<FTP_CLIENT_PROTO_CONF> FtpClient;
+class FtpClient : public Inspector
+{
+public:
+    FtpClient(FTP_CLIENT_PROTO_CONF* client) : ftp_client(client) { }
+
+    ~FtpClient() override
+    { delete ftp_client; }
+
+    void show(SnortConfig*) override;
+    void eval(Packet*) override { }
+
+    FTP_CLIENT_PROTO_CONF* ftp_client;
+};
 
-template<>
 void FtpClient::show(SnortConfig*)
 {
-    if ( data )
-        print_conf_client(data);
+    if ( ftp_client )
+        print_conf_client(ftp_client);
 }
 
 class FtpServer : public Inspector
@@ -258,7 +269,7 @@ FTP_CLIENT_PROTO_CONF* get_ftp_client(Packet* p)
         assert(client);
         p->flow->set_data(client);
     }
-    return client->data;
+    return client->ftp_client;
 }
 
 FTP_SERVER_PROTO_CONF* get_ftp_server(Packet* p)