From: Charles-Henri Bruyand <charles-henri.bruyand@open-xchange.com>
Date: Tue, 27 Mar 2018 22:44:37 +0000 (+0200)
Subject: rec: prefer references for function parameters
X-Git-Tag: dnsdist-1.3.1~184^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7afd3f740fc94be56dda723aa38d0aa937fb1355;p=thirdparty%2Fpdns.git

rec: prefer references for function parameters
---

diff --git a/pdns/dnssecinfra.cc b/pdns/dnssecinfra.cc
index 5f662d1886..7525eed641 100644
--- a/pdns/dnssecinfra.cc
+++ b/pdns/dnssecinfra.cc
@@ -460,7 +460,7 @@ DSRecordContent makeDSFromDNSKey(const DNSName& qname, const DNSKEYRecordContent
 }
 
 
-static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr<DNSCryptoKeyEngine> pk, uint8_t algorithm, uint16_t flags)
+static DNSKEYRecordContent makeDNSKEYFromDNSCryptoKeyEngine(const std::shared_ptr<DNSCryptoKeyEngine>& pk, uint8_t algorithm, uint16_t flags)
 {
   DNSKEYRecordContent drc;
 
diff --git a/pdns/filterpo.cc b/pdns/filterpo.cc
index c73b202e6b..90179584ae 100644
--- a/pdns/filterpo.cc
+++ b/pdns/filterpo.cc
@@ -231,31 +231,31 @@ void DNSFilterEngine::Zone::addNSIPTrigger(const Netmask& nm, Policy pol)
   d_propolNSAddr.insert(nm).second = pol;
 }
 
-bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmClientTrigger(const Netmask& nm, Policy& pol)
 {
   d_qpolAddr.erase(nm);
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmResponseTrigger(const Netmask& nm, Policy& pol)
 {
   d_postpolAddr.erase(nm);
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy pol)
+bool DNSFilterEngine::Zone::rmQNameTrigger(const DNSName& n, Policy& pol)
 {
   d_qpolName.erase(n); // XXX verify we had identical policy?
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy pol)
+bool DNSFilterEngine::Zone::rmNSTrigger(const DNSName& n, Policy& pol)
 {
   d_propolName.erase(n); // XXX verify policy matched? =pol;
   return true;
 }
 
-bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy pol)
+bool DNSFilterEngine::Zone::rmNSIPTrigger(const Netmask& nm, Policy& pol)
 {
   d_propolNSAddr.erase(nm);
   return true;
diff --git a/pdns/filterpo.hh b/pdns/filterpo.hh
index ba43829b49..f07d37102e 100644
--- a/pdns/filterpo.hh
+++ b/pdns/filterpo.hh
@@ -147,11 +147,11 @@ public:
     void addNSIPTrigger(const Netmask& nm, Policy pol);
     void addResponseTrigger(const Netmask& nm, Policy pol);
 
-    bool rmClientTrigger(const Netmask& nm, Policy pol);
-    bool rmQNameTrigger(const DNSName& nm, Policy pol);
-    bool rmNSTrigger(const DNSName& dn, Policy pol);
-    bool rmNSIPTrigger(const Netmask& nm, Policy pol);
-    bool rmResponseTrigger(const Netmask& nm, Policy pol);
+    bool rmClientTrigger(const Netmask& nm, Policy& pol);
+    bool rmQNameTrigger(const DNSName& nm, Policy& pol);
+    bool rmNSTrigger(const DNSName& dn, Policy& pol);
+    bool rmNSIPTrigger(const Netmask& nm, Policy& pol);
+    bool rmResponseTrigger(const Netmask& nm, Policy& pol);
 
     bool findQNamePolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const;
     bool findNSPolicy(const DNSName& qname, DNSFilterEngine::Policy& pol) const;
diff --git a/pdns/ixfr.cc b/pdns/ixfr.cc
index 56a69c1df5..c6b2137532 100644
--- a/pdns/ixfr.cc
+++ b/pdns/ixfr.cc
@@ -27,7 +27,7 @@
 #include "tsigverifier.hh"
 
 vector<pair<vector<DNSRecord>, vector<DNSRecord> > > processIXFRRecords(const ComboAddress& master, const DNSName& zone,
-                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent> masterSOA)
+                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent>& masterSOA)
 {
   vector<pair<vector<DNSRecord>, vector<DNSRecord> > >  ret;
 
diff --git a/pdns/ixfr.hh b/pdns/ixfr.hh
index 970222f7e5..1d9606a1e9 100644
--- a/pdns/ixfr.hh
+++ b/pdns/ixfr.hh
@@ -29,4 +29,4 @@ vector<pair<vector<DNSRecord>, vector<DNSRecord> > >   getIXFRDeltas(const Combo
                                                                      const ComboAddress* laddr=0, size_t maxReceivedBytes=0);
 
 vector<pair<vector<DNSRecord>, vector<DNSRecord> > > processIXFRRecords(const ComboAddress& master, const DNSName& zone,
-                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent> masterSOA);
+                                                                        const vector<DNSRecord>& records, const std::shared_ptr<SOARecordContent>& masterSOA);
diff --git a/pdns/sortlist.hh b/pdns/sortlist.hh
index 188728b3b4..cd043295ac 100644
--- a/pdns/sortlist.hh
+++ b/pdns/sortlist.hh
@@ -31,7 +31,7 @@ struct SortListOrder
 
 struct SortListOrderCmp
 {
-  SortListOrderCmp(SortListOrder slo) : d_slo(slo) {}
+  SortListOrderCmp(const SortListOrder& slo) : d_slo(slo) {}
   bool operator()(const DNSRecord& a, const DNSRecord& b) const;
   const SortListOrder d_slo;
 };