From: lpsolit%gmail.com <>
Date: Tue, 21 Jun 2005 03:22:36 +0000 (+0000)
Subject: Bug 298196: process_bug.cgi updates delta_ts even when no modifications are made... 
X-Git-Tag: bugzilla-2.20rc1~46
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b043a40aa3b90ce29855a5a23bebc49cb8cf5c9;p=thirdparty%2Fbugzilla.git

Bug 298196: process_bug.cgi updates delta_ts even when no modifications are made - Patch by Frédéric Buclin <LpSolit@gmail.com> r=mkanat a=myk
---

diff --git a/process_bug.cgi b/process_bug.cgi
index d974748633..c90ed42d9c 100755
--- a/process_bug.cgi
+++ b/process_bug.cgi
@@ -1444,9 +1444,8 @@ foreach my $id (@idlist) {
             while (MoreSQLData()) {
                 push(@list, FetchOneColumn());
             }
-            SendSQL("UPDATE bugs SET delta_ts = $sql_timestamp, keywords = " .
-                    SqlQuote(join(', ', @list)) .
-                    " WHERE bug_id = $id");
+            $dbh->do("UPDATE bugs SET keywords = ? WHERE bug_id = ?",
+                     undef, join(', ', @list), $id);
         }
     }
     my $query = "$basequery\nwhere bug_id = $id";
@@ -1735,7 +1734,7 @@ foreach my $id (@idlist) {
     $i = 0;
     foreach my $col (@::log_columns) {
         # Consider NULL db entries to be equivalent to the empty string
-        $newvalues[$i] ||= '';
+        $newvalues[$i] = defined($newvalues[$i]) ? $newvalues[$i] : '';
         # Convert the deadline to the YYYY-MM-DD format.
         if ($col eq 'deadline') {
             $newvalues[$i] = format_time($newvalues[$i], "%Y-%m-%d");