From: Ján Tomko <jtomko@redhat.com>
Date: Wed, 23 Sep 2020 16:45:52 +0000 (+0200)
Subject: storage: createFileDir: remove useless 'err' variable
X-Git-Tag: v6.8.0-rc1~17
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b100461a44f3df9c89ea791adb1259a52f4cee8;p=thirdparty%2Flibvirt.git

storage: createFileDir: remove useless 'err' variable

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
---

diff --git a/src/storage/storage_util.c b/src/storage/storage_util.c
index 08d9bd4172..7bcc0ee832 100644
--- a/src/storage/storage_util.c
+++ b/src/storage/storage_util.c
@@ -1997,7 +1997,6 @@ createFileDir(virStoragePoolObjPtr pool,
               unsigned int flags)
 {
     virStoragePoolDefPtr def = virStoragePoolObjGetDef(pool);
-    int err;
 
     virCheckFlags(0, -1);
 
@@ -2015,14 +2014,14 @@ createFileDir(virStoragePoolObjPtr pool,
     }
 
 
-    if ((err = virDirCreate(vol->target.path,
-                            (vol->target.perms->mode == (mode_t)-1 ?
-                             VIR_STORAGE_DEFAULT_VOL_PERM_MODE :
-                             vol->target.perms->mode),
-                            vol->target.perms->uid,
-                            vol->target.perms->gid,
-                            (def->type == VIR_STORAGE_POOL_NETFS
-                             ? VIR_DIR_CREATE_AS_UID : 0))) < 0) {
+    if (virDirCreate(vol->target.path,
+                     (vol->target.perms->mode == (mode_t)-1 ?
+                      VIR_STORAGE_DEFAULT_VOL_PERM_MODE :
+                      vol->target.perms->mode),
+                     vol->target.perms->uid,
+                     vol->target.perms->gid,
+                     (def->type == VIR_STORAGE_POOL_NETFS
+                      ? VIR_DIR_CREATE_AS_UID : 0)) < 0) {
         return -1;
     }