From: Josh Soref <2119212+jsoref@users.noreply.github.com>
Date: Sun, 9 Nov 2025 00:13:20 +0000 (-0500)
Subject: chore: Remove unreachable cleanup
X-Git-Tag: rec-5.4.0-alpha1~116^2~1
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b31e015593d74ad071adf0fea77374b83f05907;p=thirdparty%2Fpdns.git

chore: Remove unreachable cleanup

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
---

diff --git a/contrib/ProtobufLogger.py b/contrib/ProtobufLogger.py
index 1fea0a1cf3..7eab3bce0d 100644
--- a/contrib/ProtobufLogger.py
+++ b/contrib/ProtobufLogger.py
@@ -427,8 +427,6 @@ class PDNSPBListener(object):
             thread.daemon = True
             thread.start()
 
-        self._sock.close()
-
 
 if __name__ == "__main__":
     oturl = None
diff --git a/regression-tests.auth-py/test_Carbon.py b/regression-tests.auth-py/test_Carbon.py
index 41b53cf67f..18d6e23f7c 100644
--- a/regression-tests.auth-py/test_Carbon.py
+++ b/regression-tests.auth-py/test_Carbon.py
@@ -58,7 +58,6 @@ class TestCarbon(AuthTest):
                 cls._carbonCounters[threading.currentThread().name] = 1
 
             conn.close()
-        sock.close()
 
     @classmethod
     def startResponders(cls):
diff --git a/regression-tests.recursor-dnssec/recursortests.py b/regression-tests.recursor-dnssec/recursortests.py
index df4c6b222d..18d897fc98 100644
--- a/regression-tests.recursor-dnssec/recursortests.py
+++ b/regression-tests.recursor-dnssec/recursortests.py
@@ -33,7 +33,6 @@ def have_ipv6():
         return True
     except:
         return False
-    return False
 
 
 class RecursorTest(AssertEqualDNSMessageMixin, unittest.TestCase):
diff --git a/regression-tests.recursor-dnssec/test_Carbon.py b/regression-tests.recursor-dnssec/test_Carbon.py
index 743145e290..37bb3d4726 100644
--- a/regression-tests.recursor-dnssec/test_Carbon.py
+++ b/regression-tests.recursor-dnssec/test_Carbon.py
@@ -58,7 +58,6 @@ class CarbonTest(RecursorTest):
                 cls._carbonCounters[threading.current_thread().name] = 1
 
             conn.close()
-        sock.close()
 
     @classmethod
     def startResponders(cls):