From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Sat, 4 Nov 2017 00:17:55 +0000 (+0200)
Subject: director: Avoid str_printfa() in login_host_callback()
X-Git-Tag: 2.3.0.rc1~570
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b3acba3f2baf9710bf9b2bb17cdb92ff8937714;p=thirdparty%2Fdovecot%2Fcore.git

director: Avoid str_printfa() in login_host_callback()

Optimizes the CPU usage.
---

diff --git a/src/director/login-connection.c b/src/director/login-connection.c
index 230acb7aa1..5219c9ca9e 100644
--- a/src/director/login-connection.c
+++ b/src/director/login-connection.c
@@ -159,14 +159,19 @@ login_host_callback(const struct mail_host *host, const char *hostname,
 		line = request->line;
 	} else {
 		string_t *str = t_str_new(64);
+		char secs_buf[MAX_INT_STRLEN];
 
 		secs = dir->set->director_user_expire / 2;
-		str_printfa(str, "%s\tproxy_refresh=%u\t", request->line, secs);
+		str_append(str, request->line);
+		str_append(str, "\tproxy_refresh=");
+		str_append(str, dec2str_buf(secs_buf, secs));
+		str_append(str, "\thost=");
 		if (hostname == NULL || hostname[0] == '\0')
-			str_printfa(str, "host=%s", host->ip_str);
+			str_append(str, host->ip_str);
 		else {
-			str_printfa(str, "host=%s\thostip=%s",
-				    hostname, host->ip_str);
+			str_append(str, hostname);
+			str_append(str, "\thostip=");
+			str_append(str, host->ip_str);
 		}
 		line = str_c(str);
 	}