From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Thu, 7 Sep 2023 14:56:28 +0000 (+0200)
Subject: qemu: Add some sanity checks
X-Git-Tag: v16~2^2~2
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b8bbaa8498686d2fb84ffa3aa85860228215c5a;p=thirdparty%2Fmkosi.git

qemu: Add some sanity checks
---

diff --git a/mkosi/qemu.py b/mkosi/qemu.py
index 23d09febf..1aab8628e 100644
--- a/mkosi/qemu.py
+++ b/mkosi/qemu.py
@@ -216,6 +216,15 @@ def copy_ephemeral(config: MkosiConfig, src: Path) -> Iterator[Path]:
 
 
 def run_qemu(args: MkosiArgs, config: MkosiConfig) -> None:
+    if config.output_format not in (OutputFormat.disk, OutputFormat.cpio, OutputFormat.uki):
+        die(f"{config.output_format} images cannot be booted in qemu")
+
+    if config.output_format == OutputFormat.uki and config.qemu_firmware not in (QemuFirmware.auto, QemuFirmware.uefi):
+        die(f"uki images cannot be booted with the '{config.qemu_firmware}' firmware")
+
+    if config.output_format == OutputFormat.cpio and config.qemu_firmware not in (QemuFirmware.auto, QemuFirmware.direct, QemuFirmware.uefi):
+        die(f"cpio images cannot be booted with the '{config.qemu_firmware}' firmware")
+
     accel = "tcg"
     auto = config.qemu_kvm == ConfigFeature.auto and config.architecture.is_native() and qemu_check_kvm_support(log=True)
     if config.qemu_kvm == ConfigFeature.enabled or auto: