From: Herst <Herst@users.noreply.github.com>
Date: Mon, 3 Sep 2018 15:55:04 +0000 (+0200)
Subject: Added type="button" to <button>s without any type (#27174)
X-Git-Tag: v4.2.0~334
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7b9c8e8eb34618f294ee6585aaa866205402bb49;p=thirdparty%2Fbootstrap.git

Added type="button" to <button>s without any type (#27174)

(again)

https://github.com/twbs/bootlint/wiki/W007
---

diff --git a/site/docs/4.1/assets/js/src/application.js b/site/docs/4.1/assets/js/src/application.js
index 7666da065d..6938b9ebe9 100644
--- a/site/docs/4.1/assets/js/src/application.js
+++ b/site/docs/4.1/assets/js/src/application.js
@@ -54,7 +54,7 @@
 
     // Insert copy to clipboard button before .highlight
     $('figure.highlight, div.highlight').each(function () {
-      var btnHtml = '<div class="bd-clipboard"><button class="btn-clipboard" title="Copy to clipboard">Copy</button></div>'
+      var btnHtml = '<div class="bd-clipboard"><button type="button" class="btn-clipboard" title="Copy to clipboard">Copy</button></div>'
       $(this).before(btnHtml)
       $('.btn-clipboard')
         .tooltip()
diff --git a/site/docs/4.1/components/modal.md b/site/docs/4.1/components/modal.md
index 2da7d8f3c3..a29347b6f3 100644
--- a/site/docs/4.1/components/modal.md
+++ b/site/docs/4.1/components/modal.md
@@ -522,7 +522,7 @@ Our default modal without modifier class constitutes the "medium" size modal.
 
 {% highlight html %}
 <!-- Extra large modal -->
-<button class="btn btn-primary" data-toggle="modal" data-target=".bd-example-modal-xl">Extra large modal</button>
+<button type="button" class="btn btn-primary" data-toggle="modal" data-target=".bd-example-modal-xl">Extra large modal</button>
 
 <div class="modal fade bd-example-modal-xl" tabindex="-1" role="dialog" aria-labelledby="myExtraLargeModalLabel" aria-hidden="true">
   <div class="modal-dialog modal-xl">
diff --git a/site/docs/4.1/examples/dashboard/index.html b/site/docs/4.1/examples/dashboard/index.html
index f66c4505dd..3578f7a747 100644
--- a/site/docs/4.1/examples/dashboard/index.html
+++ b/site/docs/4.1/examples/dashboard/index.html
@@ -110,10 +110,10 @@
             <h1 class="h2">Dashboard</h1>
             <div class="btn-toolbar mb-2 mb-md-0">
               <div class="btn-group mr-2">
-                <button class="btn btn-sm btn-outline-secondary">Share</button>
-                <button class="btn btn-sm btn-outline-secondary">Export</button>
+                <button type="button" class="btn btn-sm btn-outline-secondary">Share</button>
+                <button type="button" class="btn btn-sm btn-outline-secondary">Export</button>
               </div>
-              <button class="btn btn-sm btn-outline-secondary dropdown-toggle">
+              <button type="button" class="btn btn-sm btn-outline-secondary dropdown-toggle">
                 <span data-feather="calendar"></span>
                 This week
               </button>