From: Arran Cudbard-Bell <a.cudbardb@freeradius.org>
Date: Tue, 15 Nov 2022 14:20:43 +0000 (-0600)
Subject: Fail on internal exec error
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7bae097d63dbf9f63dece47e135320fac06ac1db;p=thirdparty%2Ffreeradius-server.git

Fail on internal exec error
---

diff --git a/src/lib/server/exec.c b/src/lib/server/exec.c
index 24e20c3c4ac..1a883a2bfdf 100644
--- a/src/lib/server/exec.c
+++ b/src/lib/server/exec.c
@@ -596,7 +596,7 @@ void fr_exec_cleanup(fr_exec_state_t *exec, int signal)
 	if (exec->pid >= 0) {
 		RDEBUG3("Cleaning up exec state for PID %u", exec->pid);
 	} else {
-		RDEBUG3("Cleaning up failed exec for PID %u", exec->pid);
+		RDEBUG3("Cleaning up failed exec");
 	}
 
 	/*
diff --git a/src/modules/rlm_exec/rlm_exec.c b/src/modules/rlm_exec/rlm_exec.c
index b6f578d3f7f..6197a6d79d3 100644
--- a/src/modules/rlm_exec/rlm_exec.c
+++ b/src/modules/rlm_exec/rlm_exec.c
@@ -452,6 +452,8 @@ static unlang_action_t CC_HINT(nonnull) mod_exec_dispatch(rlm_rcode_t *p_result,
 	}
 
 	MEM(m = talloc_zero(ctx, rlm_exec_ctx_t));
+	m->status = 2;	/* Fail if we couldn't exec */
+
 	fr_value_box_list_init(&m->box);
 	return unlang_module_yield_to_tmpl(m, &m->box,
 					   request, inst->tmpl,