From: Alan T. DeKok <aland@freeradius.org>
Date: Sun, 12 Jun 2022 15:14:30 +0000 (-0400)
Subject: we shouldn't be copying structural groups.
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7bb53cdf7b16ccd15e57a420654a758d3d25f61d;p=thirdparty%2Ffreeradius-server.git

we shouldn't be copying structural groups.

We may change this later, but for now let's disallow it until all
of the tests pass.
---

diff --git a/src/lib/unlang/xlat_eval.c b/src/lib/unlang/xlat_eval.c
index 66d1ea56e2a..95dfe091f2b 100644
--- a/src/lib/unlang/xlat_eval.c
+++ b/src/lib/unlang/xlat_eval.c
@@ -950,6 +950,7 @@ xlat_eval_pair_real(TALLOC_CTX *ctx, fr_value_box_list_t *out, request_t *reques
 		value = fr_value_box_alloc(ctx, vp->data.type, vp->da, vp->data.tainted);
 		if (!value) goto oom;
 
+		fr_assert(fr_type_is_leaf(vp->da->type));
 		fr_value_box_copy(value, value, &vp->data);	/* Also dups taint */
 		fr_dlist_insert_tail(out, value);
 		break;