From: Joseph Sutton <josephsutton@catalyst.net.nz>
Date: Mon, 13 Sep 2021 09:14:18 +0000 (+1200)
Subject: tests/krb5: Sign-extend kvno from 32-bit integer
X-Git-Tag: ldb-2.5.0~644
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7bc52cecb442c4bcbd39372a8b98bb033e4d1540;p=thirdparty%2Fsamba.git

tests/krb5: Sign-extend kvno from 32-bit integer

This helps to avoid problems with RODC kvnos that have the high bit set.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14642

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
---

diff --git a/python/samba/tests/krb5/raw_testcase.py b/python/samba/tests/krb5/raw_testcase.py
index 164d06b9788..cca38fb9480 100644
--- a/python/samba/tests/krb5/raw_testcase.py
+++ b/python/samba/tests/krb5/raw_testcase.py
@@ -294,6 +294,9 @@ class KerberosCredentials(Credentials):
         return self._get_krb5_etypes(self.ap_supported_enctypes)
 
     def set_kvno(self, kvno):
+        # Sign-extend from 32 bits.
+        if kvno & 1 << 31:
+            kvno |= -1 << 31
         self.kvno = kvno
 
     def get_kvno(self):