From: Jim Meyering <meyering@redhat.com>
Date: Wed, 7 Apr 2010 18:17:44 +0000 (+0200)
Subject: xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain
X-Git-Tag: v0.8.0~31
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7be5c26d746643b5ba889d62212a615050fed772;p=thirdparty%2Flibvirt.git

xenXMDomainDefineXML: remove dead store and useless/leaky virGetDomain

* src/xen/xm_internal.c (xenXMDomainDefineXML): Remove useless and
leak-inducing call to virGetDomain, as well as decl of now-unused local.
---

diff --git a/src/xen/xm_internal.c b/src/xen/xm_internal.c
index d1265ba36b..a7a09a0f74 100644
--- a/src/xen/xm_internal.c
+++ b/src/xen/xm_internal.c
@@ -2622,7 +2622,6 @@ cleanup:
  */
 virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) {
     virDomainPtr ret;
-    virDomainPtr olddomain;
     char filename[PATH_MAX];
     const char * oldfilename;
     virDomainDefPtr def = NULL;
@@ -2688,10 +2687,6 @@ virDomainPtr xenXMDomainDefineXML(virConnectPtr conn, const char *xml) {
             goto error;
         }
 
-        /* XXX wtf.com is this line for - it appears to be amemory leak */
-        if (!(olddomain = virGetDomain(conn, def->name, entry->def->uuid)))
-            goto error;
-
         /* Remove the name -> filename mapping */
         if (virHashRemoveEntry(priv->nameConfigMap, def->name, NULL) < 0) {
             xenXMError(VIR_ERR_INTERNAL_ERROR,