From: NeilBrown <neilb@suse.de>
Date: Mon, 21 Mar 2011 23:32:09 +0000 (+1100)
Subject: ddf: fix up detection of failed/missing devices.
X-Git-Tag: mdadm-3.1.5~4
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c19b781d511211fcee0d9482bbccc7217a5f7f9;p=thirdparty%2Fmdadm.git

ddf: fix up detection of failed/missing devices.

If a device hasn't been found yet we can still tell if it is
expected to be working, and we must to do to make sure
'working_disks' is correct.

Signed-off-by: NeilBrown <neilb@suse.de>
---

diff --git a/super-ddf.c b/super-ddf.c
index 93de7502..79293645 100644
--- a/super-ddf.c
+++ b/super-ddf.c
@@ -3033,23 +3033,33 @@ static struct mdinfo *container_content_ddf(struct supertype *st)
 			struct mdinfo *dev;
 			struct dl *d;
 			int stt;
+			int pd;
 
 			if (vc->conf.phys_refnum[i] == 0xFFFFFFFF)
 				continue;
 
-			for (d = ddf->dlist; d ; d=d->next)
-				if (d->disk.refnum == vc->conf.phys_refnum[i])
+			for (pd = __be16_to_cpu(ddf->phys->used_pdes);
+			     pd--;)
+				if (ddf->phys->entries[pd].refnum
+				    == vc->conf.phys_refnum[i])
 					break;
-			if (d == NULL)
-				/* Haven't found that one yet, maybe there are others */
+			if (pd < 0)
 				continue;
-			stt = __be16_to_cpu(ddf->phys->entries[d->pdnum].state);
+
+			stt = __be16_to_cpu(ddf->phys->entries[pd].state);
 			if ((stt & (DDF_Online|DDF_Failed|DDF_Rebuilding))
 			    != DDF_Online)
 				continue;
 
 			this->array.working_disks++;
 
+			for (d = ddf->dlist; d ; d=d->next)
+				if (d->disk.refnum == vc->conf.phys_refnum[i])
+					break;
+			if (d == NULL)
+				/* Haven't found that one yet, maybe there are others */
+				continue;
+
 			dev = malloc(sizeof(*dev));
 			memset(dev, 0, sizeof(*dev));
 			dev->next = this->devs;