From: Lennart Poettering <lennart@poettering.net>
Date: Mon, 27 May 2024 17:06:08 +0000 (+0200)
Subject: machined: downgrade warning if we cannot drop ref to systemd unit if disconnected... 
X-Git-Tag: v256-rc4~105
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c1a1aa42c474daee5b90f102285676fd9cafd6c;p=thirdparty%2Fsystemd.git

machined: downgrade warning if we cannot drop ref to systemd unit if disconnected from bus

if machined exits while a machine is still running, we'll issue the
UnrefUnit() call on the unit. This quite likely will fail if during
shutdown the bus connection is already down. But that's no reason to
warn at all, since the ref count will implicitly be dropped if our side
disappears from the bus. Hence, downgrade to LOG_DEBUG in case of
connection problems.
---

diff --git a/src/machine/machine.c b/src/machine/machine.c
index 5c21a039e5e..0eb9a55e5f7 100644
--- a/src/machine/machine.c
+++ b/src/machine/machine.c
@@ -675,8 +675,9 @@ void machine_release_unit(Machine *m) {
 
                 r = manager_unref_unit(m->manager, m->unit, &error);
                 if (r < 0)
-                        log_warning_errno(r, "Failed to drop reference to machine scope, ignoring: %s",
-                                          bus_error_message(&error, r));
+                        log_full_errno(ERRNO_IS_DISCONNECT(r) ? LOG_DEBUG : LOG_WARNING, r,
+                                       "Failed to drop reference to machine scope, ignoring: %s",
+                                       bus_error_message(&error, r));
 
                 m->referenced = false;
         }