From: Volker Lendecke <vl@samba.org>
Date: Tue, 15 Dec 2020 16:15:21 +0000 (+0100)
Subject: libsmbclient: Avoid a call to SMBC_errno() in SMBC_chmod_ctx()
X-Git-Tag: ldb-2.5.0~1005
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c2b6a71dced8cfd2fcea138660089924aaf5a46;p=thirdparty%2Fsamba.git

libsmbclient: Avoid a call to SMBC_errno() in SMBC_chmod_ctx()

Directly use the return value from cli_setatr(), don't go via the cli_state
struct member

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/libsmb_dir.c b/source3/libsmb/libsmb_dir.c
index b7a5c2504e6..54902ed773f 100644
--- a/source3/libsmb/libsmb_dir.c
+++ b/source3/libsmb/libsmb_dir.c
@@ -2048,9 +2048,10 @@ SMBC_chmod_ctx(SMBCCTX *context,
 	if ((newmode & S_IXGRP) && lp_map_system(-1)) attr |= FILE_ATTRIBUTE_SYSTEM;
 	if ((newmode & S_IXOTH) && lp_map_hidden(-1)) attr |= FILE_ATTRIBUTE_HIDDEN;
 
-	if (!NT_STATUS_IS_OK(cli_setatr(targetcli, targetpath, attr, 0))) {
-		errno = SMBC_errno(context, targetcli);
+	status = cli_setatr(targetcli, targetpath, attr, 0);
+	if (!NT_STATUS_IS_OK(status)) {
 		TALLOC_FREE(frame);
+		errno = cli_status_to_errno(status);
 		return -1;
 	}