From: Matt Caswell <matt@openssl.org>
Date: Thu, 11 Aug 2022 11:02:44 +0000 (+0100)
Subject: Don't incorrectly skip the multiblock test
X-Git-Tag: openssl-3.2.0-alpha1~2275
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c82a7a8f3a66f47f727d31691d6298d88ed158b;p=thirdparty%2Fopenssl.git

Don't incorrectly skip the multiblock test

sslapitest has a test for multiblock writes. Since multiblock writing is
only available on some platforms the multiblock test checks whether we are
on such a platform first, and skips the test if we are not. Unfortunately
a bug in the check meant that we always skipped the test regardless of the
platform.

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Hugo Landau <hlandau@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18983)
---

diff --git a/test/sslapitest.c b/test/sslapitest.c
index bf2e75c7249..3f8cbd9da28 100644
--- a/test/sslapitest.c
+++ b/test/sslapitest.c
@@ -8470,7 +8470,7 @@ static int test_multiblock_write(int test_index)
      * Check if the cipher exists before attempting to use it since it only has
      * a hardware specific implementation.
      */
-    ciph = EVP_CIPHER_fetch(NULL, fetchable_ciphers[test_index], "");
+    ciph = EVP_CIPHER_fetch(libctx, fetchable_ciphers[test_index], "");
     if (ciph == NULL) {
         TEST_skip("Multiblock cipher is not available for %s", cipherlist);
         return 1;