From: Alan T. DeKok <aland@freeradius.org>
Date: Mon, 11 Apr 2022 23:45:50 +0000 (-0400)
Subject: Check for NULL, and free on error.  CID #1503946
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7c8e22b55437b2a34a69e324c31e9c4d8f69a57e;p=thirdparty%2Ffreeradius-server.git

Check for NULL, and free on error.  CID #1503946
---

diff --git a/src/modules/rlm_csv/rlm_csv.c b/src/modules/rlm_csv/rlm_csv.c
index 37453281eee..3fb4ac47c12 100644
--- a/src/modules/rlm_csv/rlm_csv.c
+++ b/src/modules/rlm_csv/rlm_csv.c
@@ -230,9 +230,13 @@ static bool duplicate_entry(CONF_SECTION *conf, rlm_csv_t *inst, rlm_csv_entry_t
 	talloc_set_type(e, rlm_csv_entry_t);
 
 	e->key = fr_value_box_alloc_null(e);
+	if (!e->key) goto fail;
+
 	if (fr_value_box_from_str(e->key, e->key, type, NULL, p, strlen(p), NULL, false) < 0) {
 		cf_log_err(conf, "Failed parsing key field in file %s line %d - %s", inst->filename, lineno,
 			   fr_strerror());
+	fail:
+		talloc_free(e);
 		return false;
 	}