From: Michael Tremer Date: Wed, 13 Mar 2019 13:08:19 +0000 (+0000) Subject: libpakfire: archive: Return extra error code when no signatures exist X-Git-Tag: 0.9.28~1285^2~1075 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7cc7f818337775786b0de441af211cc98c72b347;p=pakfire.git libpakfire: archive: Return extra error code when no signatures exist Signed-off-by: Michael Tremer --- diff --git a/src/libpakfire/archive.c b/src/libpakfire/archive.c index 5e082110b..d24419351 100644 --- a/src/libpakfire/archive.c +++ b/src/libpakfire/archive.c @@ -832,15 +832,14 @@ PAKFIRE_EXPORT PakfireArchiveSignature* pakfire_archive_get_signatures(PakfireAr static pakfire_archive_verify_status_t pakfire_archive_verify_checksums(PakfireArchive archive) { DEBUG(archive->pakfire, "Verifying checksums of %p\n", archive); - pakfire_archive_verify_status_t status = PAKFIRE_ARCHIVE_VERIFY_INVALID; - // Cannot validate anything if no signatures are available PakfireArchiveSignature* signatures = pakfire_archive_get_signatures(archive); if (!signatures) { ERROR(archive->pakfire, "Archive %p does not have any signatures\n", archive); - return PAKFIRE_ARCHIVE_VERIFY_OK; + return PAKFIRE_ARCHIVE_VERIFY_NO_SIGNATURES; } + pakfire_archive_verify_status_t status = PAKFIRE_ARCHIVE_VERIFY_INVALID; const char* data = NULL; size_t size = 0; gpgme_error_t error; diff --git a/src/libpakfire/include/pakfire/archive.h b/src/libpakfire/include/pakfire/archive.h index 62daef301..a60432da7 100644 --- a/src/libpakfire/include/pakfire/archive.h +++ b/src/libpakfire/include/pakfire/archive.h @@ -27,6 +27,7 @@ typedef enum pakfire_archive_verify_status { PAKFIRE_ARCHIVE_VERIFY_OK = 0, + PAKFIRE_ARCHIVE_VERIFY_NO_SIGNATURES, PAKFIRE_ARCHIVE_VERIFY_INVALID, PAKFIRE_ARCHIVE_VERIFY_SIG_EXPIRED, PAKFIRE_ARCHIVE_VERIFY_KEY_EXPIRED,