From: Volker Lendecke <vl@samba.org>
Date: Sun, 18 Oct 2020 20:43:41 +0000 (+0200)
Subject: libsmb: Use a direct struct initialization to avoid a memset
X-Git-Tag: talloc-2.3.2~207
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7ce22e2f57489bff26bb1e5e379d5081d46710f2;p=thirdparty%2Fsamba.git

libsmb: Use a direct struct initialization to avoid a memset

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
---

diff --git a/source3/libsmb/clifile.c b/source3/libsmb/clifile.c
index 42b964dbabe..6f6ede24152 100644
--- a/source3/libsmb/clifile.c
+++ b/source3/libsmb/clifile.c
@@ -5205,7 +5205,7 @@ NTSTATUS cli_set_ea_fnum(struct cli_state *cli, uint16_t fnum,
 			 const char *ea_name, const char *ea_val,
 			 size_t ea_len)
 {
-	uint8_t param[6];
+	uint8_t param[6] = { 0, };
 
 	if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
 		return cli_smb2_set_ea_fnum(cli,
@@ -5215,7 +5215,6 @@ NTSTATUS cli_set_ea_fnum(struct cli_state *cli, uint16_t fnum,
 					ea_len);
 	}
 
-	memset(param, 0, 6);
 	SSVAL(param,0,fnum);
 	SSVAL(param,2,SMB_INFO_SET_EA);