From: Tilghman Lesher <tilghman@meg.abyt.es>
Date: Sun, 6 Jun 2010 00:37:30 +0000 (+0000)
Subject: Finally track down and eliminate the "FRACK! warnings from chan_iax2".
X-Git-Tag: 11.0.0-beta1~2899
X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d18dd539471249b080fc4babca9c0a708ddc08a;p=thirdparty%2Fasterisk.git

Finally track down and eliminate the "FRACK! warnings from chan_iax2".


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@268495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
---

diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c
index 30f9d721a2..04ce7ee7b7 100644
--- a/channels/chan_iax2.c
+++ b/channels/chan_iax2.c
@@ -3281,7 +3281,16 @@ static void iax2_destroy(int callno)
 
 retry:
 	if ((pvt = iaxs[callno])) {
+#if 0
+		/* iax2_destroy_helper gets called from this function later on.  When
+		 * called twice, we get the (previously) familiar FRACK! errors in
+		 * devmode, from the scheduler.  An alternative to this approach is to
+		 * reset the scheduler entries to -1 when they're deleted in
+		 * iax2_destroy_helper().  That approach was previously decided to be
+		 * "wrong" because "the memory is going to be deallocated anyway.  Why
+		 * should we be resetting those values?" */
 		iax2_destroy_helper(pvt);
+#endif
 	}
 
 	owner = pvt ? pvt->owner : NULL;