From: Kemeng Shi Date: Tue, 20 Aug 2024 13:22:34 +0000 (+0800) Subject: ext4: check buffer_verified in advance to avoid unneeded ext4_get_group_info() X-Git-Tag: v6.12-rc1~117^2~38 X-Git-Url: http://git.ipfire.org/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=7d2b48881877ace14ea85a7e3a17ff8f80f3d8e6;p=thirdparty%2Fkernel%2Fstable.git ext4: check buffer_verified in advance to avoid unneeded ext4_get_group_info() Check buffer_verified in advance to avoid unneeded ext4_get_group_info(). This could be a simple cleanup as compiler may handle this. Signed-off-by: Kemeng Shi Link: https://patch.msgid.link/20240820132234.2759926-8-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c index daacb9f0ef50a..7f1a5f90dbbdf 100644 --- a/fs/ext4/ialloc.c +++ b/fs/ext4/ialloc.c @@ -87,10 +87,10 @@ static int ext4_validate_inode_bitmap(struct super_block *sb, if (EXT4_SB(sb)->s_mount_state & EXT4_FC_REPLAY) return 0; - grp = ext4_get_group_info(sb, block_group); - if (buffer_verified(bh)) return 0; + + grp = ext4_get_group_info(sb, block_group); if (!grp || EXT4_MB_GRP_IBITMAP_CORRUPT(grp)) return -EFSCORRUPTED;